From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH 1/2] spi: Fix mapping from vmalloc-ed buffer to scatter list Date: Fri, 14 Nov 2014 16:06:07 +0000 Message-ID: <20141114160607.GB12443@opensource.wolfsonmicro.com> References: <1415979645-26264-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20141114155222.GF3815@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org To: Mark Brown Return-path: Content-Disposition: inline In-Reply-To: <20141114155222.GF3815-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Fri, Nov 14, 2014 at 03:52:22PM +0000, Mark Brown wrote: > On Fri, Nov 14, 2014 at 03:40:44PM +0000, Charles Keepax wrote: > > We can only use page_address on memory that has been mapped using kmap, > > when the buffer passed to the SPI has been allocated by vmalloc the page > > has not necessarily been mapped through kmap. This means sometimes > > page_address will return NULL causing the pointer we pass to sg_set_buf > > to be invalid. > > Hrm, this is a bug in the mxs driver (which is where we copied the core > code from) - care to fix that too? Yeah no problem, won't be able to test it, but should be a fairly trivial change and hopefully someone else can test. > > > As we only call page_address such that we can pass a virtual address to > > s/such/so/ Will ping a respin and include the mxs fixup too. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html