rockchip spi: dma engine use buggy

rockchip spi: dma engine use buggy

[Russell King - ARM Linux]

While looking at a warning which came up in my nightly builds, I spotted
this:

+               rxconf.src_addr_width = rs->n_bytes;
+               rxconf.src_maxburst = rs->n_bytes;

+               txconf.dst_addr_width = rs->n_bytes;
+               txconf.dst_maxburst = rs->n_bytes;

which is incorrect.  The documentation for the maxburst fields says:

 * @src_maxburst: the maximum number of words (note: words, as in
 * units of the src_addr_width member, not bytes) that can be sent
 * in one burst to the device. Typically something like half the
 * FIFO depth on I/O peripherals so you don't overflow it. This
 * may or may not be applicable on memory sources.
 * @dst_maxburst: same as src_maxburst but for destination target
 * mutatis mutandis.

In other words, if n_bytes is:

- one, we tell the DMA engine that it can burst one byte.
- two, we tell the DMA engine that it can burst _two_ 16-bit words,
  in other words, four bytes.
- four, we tell the DMA engine that it can burst _four_ 32-bit words,
  in other words, 16 bytes.

Somehow, I don't think that's correct.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html