From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi/spidev: Convert to use unified device property API
Date: Tue, 30 Dec 2014 09:37:14 +0200 [thread overview]
Message-ID: <20141230073714.GD1386@lahna.fi.intel.com> (raw)
In-Reply-To: <20141229160316.GO17800@sirena.org.uk>
On Mon, Dec 29, 2014 at 04:03:16PM +0000, Mark Brown wrote:
> On Mon, Dec 29, 2014 at 11:41:14AM +0200, Mika Westerberg wrote:
> > This will allow the driver to match using DT compatible property if the
> > device has ACPI _HID of "PRP0001" and accompanying "compatible" property
> > listed in _DSD.
>
> Which nobody should be doing since it's already totally broken for
> something to be using this on the DT side except in the one case of the
> Rohm device which is listed there. I don't want to merge anything which
> allows the breakage we're seeing with people putting spidev in their DTs
> to be propagated into ACPI, at most we should have something that
> specifically identifies individual devices only.
It is pretty convenient for testing SPI bus and that's why I thought
it would be good to have possibility to enumerate this in similar way
than DT does but I understand your point.
next prev parent reply other threads:[~2014-12-30 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 9:41 [PATCH] spi/spidev: Convert to use unified device property API Mika Westerberg
[not found] ` <1419846074-240217-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-29 16:03 ` Mark Brown
2014-12-30 7:37 ` Mika Westerberg [this message]
[not found] ` <20141230073714.GD1386-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-12-30 11:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141230073714.GD1386@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).