From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] spi: st-ssc4: Remove duplicate code to test unsupported mode bits Date: Sun, 18 Jan 2015 12:44:35 +0000 Message-ID: <20150118124435.GT3574@x1> References: <1420469376.6880.1.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Mark Brown , linux-spi To: Axel Lin Return-path: Content-Disposition: inline In-Reply-To: <1420469376.6880.1.camel@phoenix> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Mon, 05 Jan 2015, Axel Lin wrote: > spi_setup() will test unsupported mode bits before calling spi->maste= r->setup. > Thus remove duplicate code to test unsupported mode bits in spi_st_se= tup(). >=20 > Signed-off-by: Axel Lin > --- > drivers/spi/spi-st-ssc4.c | 6 ------ > 1 file changed, 6 deletions(-) =46WIW: Acked-by: Lee Jones > diff --git a/drivers/spi/spi-st-ssc4.c b/drivers/spi/spi-st-ssc4.c > index 8f8770a..2faeaa7 100644 > --- a/drivers/spi/spi-st-ssc4.c > +++ b/drivers/spi/spi-st-ssc4.c > @@ -217,12 +217,6 @@ static int spi_st_setup(struct spi_device *spi) > int cs =3D spi->cs_gpio; > int ret; > =20 > - if (spi->mode & ~MODEBITS) { > - dev_err(&spi->dev, "unsupported mode bits 0x%x\n", > - spi->mode & ~MODEBITS); > - return -EINVAL; > - } > - > if (!hz) { > dev_err(&spi->dev, "max_speed_hz unspecified\n"); > return -EINVAL; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html