From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Bhuvanchandra DV
<bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>,
stefan-XLVq0VzYD2Y@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'
Date: Mon, 2 Feb 2015 20:23:56 +0000 [thread overview]
Message-ID: <20150202202356.GF21293@sirena.org.uk> (raw)
In-Reply-To: <20150131164648.GR6507@mwanda>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Sat, Jan 31, 2015 at 07:46:48PM +0300, Dan Carpenter wrote:
> On Sat, Jan 31, 2015 at 10:03:25PM +0530, Bhuvanchandra DV wrote:
> > Move the check for spi->bits_per_word
> > before allocation, to avoid memory leak.
> > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Normally, you would give me a Reported-by: tag. Not a big deal either
> way.
It is a big deal - the Signed-off-by involves all the stuff in
SubmittingPatches which means that you really shouldn't add a signoff
for anyone who didn't supply one. I've changed to a Reported-by and
applied, please be more careful with this in future Bhuvanchandra.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-02-02 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 16:33 [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip' Bhuvanchandra DV
[not found] ` <1422722005-1616-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-01-31 16:46 ` Dan Carpenter
2015-02-02 20:23 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202202356.GF21293@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).