From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH] spi: trigger trace event for message-done before mesg->complete
Date: Wed, 18 Mar 2015 14:32:26 +0100 [thread overview]
Message-ID: <20150318133226.GR10068@pengutronix.de> (raw)
In-Reply-To: <20150318113635.GB2869-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Wed, Mar 18, 2015 at 11:36:35AM +0000, Mark Brown wrote:
> On Wed, Mar 18, 2015 at 11:27:28AM +0100, Uwe Kleine-König wrote:
> > With spidev the mesg->complete callback points to spidev_complete.
> > Calling this unblocks spidev_sync and so spidev_sync_write finishes. As
> > the struct spi_message just read is a local variable in
> > spidev_sync_write and recording the trace event accesses this message
> > the recording is better done first. The same can happen for
> > spidev_sync_read.
>
> Applied, thanks. I'm a bit suspicious that the changelog talks only
> about spidev though...
That's my workflow. Maybe the important thing here is also that I use
-rt?!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-18 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 10:27 [PATCH] spi: trigger trace event for message-done before mesg->complete Uwe Kleine-König
[not found] ` <1426674448-8246-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-03-18 11:36 ` Mark Brown
[not found] ` <20150318113635.GB2869-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-18 13:32 ` Uwe Kleine-König [this message]
[not found] ` <20150318133226.GR10068-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-03-18 13:58 ` Mark Brown
[not found] ` <20150318135854.GI2869-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-18 14:48 ` Uwe Kleine-König
[not found] ` <20150318144854.GS10068-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-03-19 11:24 ` Mark Brown
[not found] ` <20150319112430.GP2869-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-19 11:48 ` Uwe Kleine-König
[not found] ` <20150319114842.GU10068-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-03-19 11:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318133226.GR10068@pengutronix.de \
--to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).