Re: [PATCH 1/6] spi: bcm2835: remove dependency on handle_err which is

[Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Sun, Mar 29, 2015 at 07:03:44PM +0200, Martin Sperl wrote:
> > On 29.03.2015, at 18:48, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:

> > Why?

> > When referencing patches please include the patch title as well as the
> > hash, this makes the mail/commit log more directly readable by humans.

> This is what I have received and the patch fixes that compile issue...

...

> handle_err was introduced to for-next with b716c4ff by Andy Shevchenko
> titled: "spi: introduce master->handle_err() callback"

> But this is not included in the topic/bcm2835 branch, so the compile fails
> because of the missing handle_err in spi_master.

> If you merge that one in topic/bcm2835, then you can drop this patch.

Several things here.  First, that merge had already happened so the
problem is gone.  Secondly this is the sort of thing that needs to be in
the commit log - someone reading the commit log should be able to see
why a change is being made - and generally we should be going for the
best fix possible so it would have been better to ask for the merge.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]