From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
Rodolfo Giometti <giometti@enneenne.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Wolfram Sang <wsa@the-dreams.de>,
Takashi Iwai <tiwai@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
alsa-devel@alsa-project.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
linux-i2c@vger.kernel.org, Willy Tarreau <willy@meta-x.org>,
linux-spi@vger.kernel.org, netdev@vger.kernel.org,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH 01/14] parport: return value of attach and parport_register_driver
Date: Wed, 8 Apr 2015 14:38:32 +0300 [thread overview]
Message-ID: <20150408113832.GH10964@mwanda> (raw)
In-Reply-To: <1428492040-5581-2-git-send-email-sudipm.mukherjee@gmail.com>
1) We can't apply this patch on its own so this way of breaking up the
patches doesn't work.
2) I was thinking that all the ->attach() calls would have to succeed or
we would bail. Having some of them succeed and some fail doesn't seem
like it will simplify the driver code very much. But I can also see
your point. Hm...
Minor comment: No need to preserve the error code if there are lots
which we miss. We may as well hard code an error code. But that's a
minor thing. Does this actually simplify the driver code? That's the
more important thing.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-08 11:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 11:20 [PATCH 00/14] parport: check success of attach call Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 01/14] parport: return value of attach and parport_register_driver Sudip Mukherjee
2015-04-08 11:38 ` Dan Carpenter [this message]
2015-04-08 11:44 ` Dan Carpenter
2015-04-08 12:14 ` Sudip Mukherjee
2015-04-08 11:50 ` Sudip Mukherjee
2015-04-08 12:27 ` Dan Carpenter
2015-04-08 17:56 ` Willy Tarreau
2015-04-08 11:20 ` [PATCH 02/14] ALSA: portman2x4: return proper error values from attach Sudip Mukherjee
[not found] ` <1428492040-5581-3-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-08 13:32 ` Sergei Shtylyov
2015-04-08 13:40 ` Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 03/14] ALSA: mts64: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 04/14] staging: panel: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 05/14] spi: lm70llp: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 06/14] spi: butterfly: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 07/14] [SCSI] ppa: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 08/14] [SCSI] imm: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 09/14] pps: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 10/14] " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 11/14] net: plip: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 12/14] i2c-parport: " Sudip Mukherjee
[not found] ` <1428492040-5581-13-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-09 7:13 ` Wolfram Sang
2015-04-09 9:33 ` Jean Delvare
[not found] ` <20150409113342.5621af83-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2015-04-09 10:25 ` Wolfram Sang
2015-04-10 5:05 ` Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 13/14] ppdev: " Sudip Mukherjee
2015-04-08 11:20 ` [PATCH 14/14] char: lp: " Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408113832.GH10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=JBottomley@parallels.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.de \
--cc=willy@meta-x.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).