From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Welling Subject: Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs Date: Thu, 21 May 2015 16:04:11 -0500 Message-ID: <20150521210411.GA5406@deathray> References: <1431452337-19280-1-git-send-email-mwelling@ieee.org> <20150512191758.GX3066@sirena.org.uk> <20150521020709.GA14258@deathray> <20150521101857.GR21577@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org To: Mark Brown Return-path: Content-Disposition: inline In-Reply-To: <20150521101857.GR21577@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Thu, May 21, 2015 at 11:18:57AM +0100, Mark Brown wrote: > On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote: > > > My guess is that the set_cs needs to be called even when toggling as GPIO. > > > How should I handle this? > > It shouldn't be part of a set_cs() operation but rather part of the main > transfer operation. Okay then this patch should be reverted. Do you want to revert the patch and apply a new one or should I provide a patch that reverts the changes and fixes it all in one? Sorry for this mess.