From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org
Subject: Re: [PATCH] spi: bcm2835: fix overflow in calculation of transfer time
Date: Wed, 29 Jul 2015 15:03:31 +0100 [thread overview]
Message-ID: <20150729140331.GC11082@sirena.org.uk> (raw)
In-Reply-To: <1438155250-14476-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Wed, Jul 29, 2015 at 07:34:10AM +0000, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote:
> From: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
>
> This resulted in the use of polling mode when other approaches
> (dma or interrupts) would have been more appropriate.
Please describe the actual issue and how it's being fixed in the commit
message. In this case the fix appears to be converting the timeout
variable to a long long which will make things better but obviously
isn't a complete fix for overflows - presumably the ideal thing here is
to handle saturation better?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-29 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 7:34 [PATCH] spi: bcm2835: fix overflow in calculation of transfer time kernel-TqfNSX0MhmxHKSADF0wUEw
[not found] ` <1438155250-14476-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-07-29 14:03 ` Mark Brown [this message]
[not found] ` <20150729140331.GC11082-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-07-29 14:31 ` Martin Sperl
[not found] ` <0D1C5BFD-04A0-4074-8424-DE941B00F887-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-07-29 14:35 ` Martin Sperl
[not found] ` <0C2A92A8-867B-4BCE-8AD4-F2D297DB918F-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-07-29 16:03 ` Mark Brown
2015-07-29 14:14 ` Applied "spi: bcm2835: fix overflow in calculation of transfer time" to the spi tree Mark Brown
2015-08-14 0:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729140331.GC11082@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org \
--cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).