From: Brian Norris <computersforpeace@gmail.com>
To: Han Xu <han.xu@freescale.com>
Cc: Michal Suchanek <hramrach@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Mark Brown <broonie@kernel.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Rafal Milecki <zajec5@gmail.com>, Jagan Teki <jteki@openedev.com>,
"Andrew F. Davis" <afd@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Gabor Juhos <juhosg@openwrt.org>, Bean Huo <beanhuo@micron.com>,
Furquan Shaikh <furquan@google.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v6 03/10] mtd: fsl-quadspi: return amount of data read/written or error
Date: Wed, 2 Dec 2015 15:07:32 -0800 [thread overview]
Message-ID: <20151202230732.GT64635@google.com> (raw)
In-Reply-To: <20151202210626.GA21512@chopperman.am.freescale.net>
On Wed, Dec 02, 2015 at 03:06:28PM -0600, Han Xu wrote:
> On Wed, Dec 02, 2015 at 10:38:19AM +0000, Michal Suchanek wrote:
> > Return amount of data read/written or error as read(2)/write(2) does.
> >
> > Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> > ---
> > drivers/mtd/spi-nor/fsl-quadspi.c | 18 +++++++++++-------
> > 1 file changed, 11 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> > index 10d2b59..9beb739 100644
> > --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> > @@ -575,7 +575,7 @@ static inline void fsl_qspi_invalid(struct fsl_qspi *q)
> > writel(reg, q->iobase + QUADSPI_MCR);
> > }
> >
> > -static int fsl_qspi_nor_write(struct fsl_qspi *q, struct spi_nor *nor,
> > +static ssize_t fsl_qspi_nor_write(struct fsl_qspi *q, struct spi_nor *nor,
>
> conflict with the patch I acked.
>
> https://patchwork.ozlabs.org/patch/545925/
>
> I may change it and test on my side.
I'll let you know if I need things rebased. If conflicts are trivial, I
can handle it. But right now, the linked patch (big endian support) is
incomplete (no documentation), and Michal's was just sent today. So it
remains to be seen which will be "ready" first.
Brian
next prev parent reply other threads:[~2015-12-02 23:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 10:38 [PATCH v6 00/10] Add error checking to spi-nor read and write Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 03/10] mtd: fsl-quadspi: return amount of data read/written or error Michal Suchanek
2015-12-02 21:06 ` Han Xu
2015-12-02 23:07 ` Brian Norris [this message]
2015-12-02 10:38 ` [PATCH v6 02/10] mtd: m25p80: return amount of data transferred or error in read/write Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 01/10] mtd: spi-nor: change return value of read/write Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 06/10] mtd: spi-nor: simplify write loop Michal Suchanek
[not found] ` <2236d87ad516f118f58eb5df232d441f970c4499.1449052427.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-15 20:22 ` Han Xu
2015-12-15 23:45 ` Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 07/10] mtd: spi-nor: add read loop Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 04/10] mtd: spi-nor: check return value from read/write Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 05/10] mtd: spi-nor: stop passing around retlen Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 10/10] mtd: m25p80: read in spi_max_transfer_size chunks Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 09/10] spi: fsl-espi: expose maximum transfer size limit Michal Suchanek
2015-12-02 10:38 ` [PATCH v6 08/10] spi: expose master transfer size limitation Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202230732.GT64635@google.com \
--to=computersforpeace@gmail.com \
--cc=afd@ti.com \
--cc=beanhuo@micron.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=dwmw2@infradead.org \
--cc=furquan@google.com \
--cc=han.xu@freescale.com \
--cc=hkallweit1@gmail.com \
--cc=hramrach@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jteki@openedev.com \
--cc=juhosg@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).