From: Mark Brown <broonie@kernel.org>
To: Youngmin Nam <ym0914@gmail.com>
Cc: kgene@kernel.org, k.kozlowski@samsung.com,
linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: s3c64xx: Get fifosize via device tree
Date: Tue, 9 Feb 2016 16:10:36 +0000 [thread overview]
Message-ID: <20160209161036.GI13270@sirena.org.uk> (raw)
In-Reply-To: <1455031585-11113-1-git-send-email-ym0914@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On Wed, Feb 10, 2016 at 12:26:25AM +0900, Youngmin Nam wrote:
> SPI driver on some SoCs only differ in the fifosize of each
> SPI channel. It is useless to duplicate the s3c64xx_spi_port_config structure
> or create a compatible name for such a change.
I disagree that it is useless to do this, it means that if we realize
later that there is some other difference between the implementations
then we have the information in the DT to handle this without needing
to update the ABI.
> +Optional SoC Specific properties:
> +
> +- samsung,spi-fifosize: The fifo size supported by the SPI channel
> +
> +
In units of...? FIFO sizes do get quoted in both words and bytes so it
seems good to be clear.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-09 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 15:26 [PATCH] spi: s3c64xx: Get fifosize via device tree Youngmin Nam
2016-02-09 16:10 ` Mark Brown [this message]
[not found] ` <20160209161036.GI13270-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-14 6:28 ` Youngmin Nam
2016-02-15 18:04 ` Mark Brown
[not found] ` <1455031585-11113-1-git-send-email-ym0914-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-14 7:01 ` Krzysztof Kozlowski
[not found] ` <56C02634.8020204-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-14 8:13 ` Youngmin Nam
2016-02-14 8:31 ` Krzysztof Kozlowski
2016-02-14 13:22 ` Youngmin Nam
[not found] ` <56C07F7C.5030907-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-14 14:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209161036.GI13270@sirena.org.uk \
--to=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ym0914@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).