Re: [PATCH v2] spi: orion.c: Add direct access mode

[Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On Tue, Mar 22, 2016 at 05:44:52PM +0100, Stefan Roese wrote:
> On 22.03.2016 17:35, Thomas Petazzoni wrote:

> >Has there been any discussion on whether dynamically adding the MBus
> >window is a good idea, as opposed to statically defining it in the
> >board .dts ?

> Yes. My 1st patch version (still RFC) used fixed MBus windows instead:

> http://www.spinics.net/lists/linux-spi/msg06536.html

> Mark suggested to use dynamic windows, so that one area could be
> used for all SPI devices by switching (re-configuring) the MBus
> window:

> http://www.spinics.net/lists/linux-spi/msg06537.html

No, there's two separate things here.  The big problem with what you
originally sent was that you were defining a window per SPI device but
this is a part of the SPI controller so having to change windows per
device is just going to make the code more complex.  There's also the
separate issue of where any MBus windows we get come up with.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]