From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Po Liu <po.liu-3arQi8VN3Tc@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE
Date: Wed, 13 Apr 2016 15:06:57 +0100 [thread overview]
Message-ID: <20160413140657.GT14664@sirena.org.uk> (raw)
In-Reply-To: <1460545402-8162-1-git-send-email-po.liu-3arQi8VN3Tc@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Wed, Apr 13, 2016 at 07:03:22PM +0800, Po Liu wrote:
> When kernel config with big endian mode, spi master need
> to config regmap data value to be little endian mode. Or else,
> the kernel boot will hang.
> +#ifdef CONFIG_CPU_BIG_ENDIAN
> + .val_format_endian = REGMAP_ENDIAN_LITTLE,
> +#endif
This should be unconditionally set to native endian if the IP changes
endianness along with the CPU.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-13 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:03 [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE Po Liu
[not found] ` <1460545402-8162-1-git-send-email-po.liu-3arQi8VN3Tc@public.gmane.org>
2016-04-13 14:06 ` Mark Brown [this message]
2016-04-17 2:41 ` Scott Wood
[not found] ` <DB5PR0401MB19281A317BFB1D9001F97ABB916A0-GXldUsIPo7Z/SeJcUcAJq43W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-04-18 10:11 ` Mark Brown
[not found] ` <20160418101117.GP3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-19 2:30 ` Po Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413140657.GT14664@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=po.liu-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).