From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Scott Wood <scott.wood-3arQi8VN3Tc@public.gmane.org>
Cc: Po Liu <po.liu-3arQi8VN3Tc@public.gmane.org>,
"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE
Date: Mon, 18 Apr 2016 11:11:17 +0100 [thread overview]
Message-ID: <20160418101117.GP3217@sirena.org.uk> (raw)
In-Reply-To: <DB5PR0401MB19281A317BFB1D9001F97ABB916A0-GXldUsIPo7Z/SeJcUcAJq43W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Sun, Apr 17, 2016 at 02:41:40AM +0000, Scott Wood wrote:
> Looking more closely, the binding has a big-endian property. It says
> the default if that property is absent is native endian, which is
> insane. Fix the binding to say that little endian is the default (this
> change shouldn't break any existing trees), and make sure that's what
> the code implements. I think you need val_format_endian_default, not
> val_format_endian.
The binding defaults to little endian and (in implmentation terms)
always has done though that used to be unintentional. There *are* a
reasonable number of devices out there which are native endian, for
example most of the MIPS chips switch the endianness of the entire chip
rather than just the CPU, but most of the current usage has been on ARM
devices which only switch the core.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-18 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:03 [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE Po Liu
[not found] ` <1460545402-8162-1-git-send-email-po.liu-3arQi8VN3Tc@public.gmane.org>
2016-04-13 14:06 ` Mark Brown
2016-04-17 2:41 ` Scott Wood
[not found] ` <DB5PR0401MB19281A317BFB1D9001F97ABB916A0-GXldUsIPo7Z/SeJcUcAJq43W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-04-18 10:11 ` Mark Brown [this message]
[not found] ` <20160418101117.GP3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-19 2:30 ` Po Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418101117.GP3217@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=po.liu-3arQi8VN3Tc@public.gmane.org \
--cc=scott.wood-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).