From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yao Yuan <yao.yuan-3arQi8VN3Tc@public.gmane.org>
Cc: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"pawel.moll-5wv7dgnIgG8@public.gmane.org"
<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ@public.gmane.org"
<linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ@public.gmane.org>,
"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Yang-Leo Li <leoyang.li-3arQi8VN3Tc@public.gmane.org>,
Scott Wood <scott.wood-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [PATCH 1/2] spi: spi-fsl-dspi: replace regmap R/W with internal implementation
Date: Thu, 12 May 2016 17:31:31 +0100 [thread overview]
Message-ID: <20160512163131.GF6261@sirena.org.uk> (raw)
In-Reply-To: <AM2PR04MB0722180ABF5DB9406F56162B89700-IPoeDzmMJYrzmGvksFXQpM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Mon, May 09, 2016 at 10:58:08AM +0000, Yao Yuan wrote:
> For example, if DSPI controller register is BE, so I set big-endian in DT.
> That means we should R/W the DSPI controller register with big-endian.
> Then I can think all of the value we R/W to/from DSPI controller register, we can
> Think they are the BE.
> So that we can understand it easy.
> That means no matter core is LE or BE, we both need get the value from DSPI register
> with big endian.
That's not how regmap is intended to be used, the intention is that the
driver will interact with native endian values and regmap will hide the
endianness changes. You could mask this with some cpu_to_be() and
be_to_cpu() usage but I'm not sure it's a great idea or what it's buying
you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-12 16:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 8:12 [PATCH 0/2] spi: spi-fsl-dspi: replace regmap R/W with internal implementation Yuan Yao
[not found] ` <1461744756-31481-1-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2016-04-27 8:12 ` [PATCH 1/2] " Yuan Yao
[not found] ` <1461744756-31481-2-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2016-04-27 15:25 ` Mark Brown
[not found] ` <20160427152532.GX3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-09 8:48 ` Yao Yuan
[not found] ` <AM2PR04MB072250B43DE37A38E374679989700-IPoeDzmMJYrzmGvksFXQpM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-09 10:28 ` Mark Brown
[not found] ` <20160509102840.GB6292-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-09 10:58 ` Yao Yuan
[not found] ` <AM2PR04MB0722180ABF5DB9406F56162B89700-IPoeDzmMJYrzmGvksFXQpM9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-11 22:20 ` Leo Li
[not found] ` <CADRPPNT2OpNxdQV8f_-S_DJjySEOu=SyegLMKU650hxuvr3CYw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-12 13:40 ` [linux-devel] " Po Liu
[not found] ` <VI1PR0401MB1709B075CEE16F3EF3CD4A9292730-9IDQY6o3qQhWumToEB7uiI3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-05-13 5:52 ` Yao Yuan
2016-05-12 16:31 ` Mark Brown [this message]
[not found] ` <20160512163131.GF6261-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-12 23:55 ` Leo Li
[not found] ` <CADRPPNSA_2Wy+O1t0ggugp0eJL2q61s_m-rWzqNnLRB0fhF1Cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-13 0:27 ` Mark Brown
2016-05-13 2:29 ` Scott Wood
[not found] ` <DB5PR0401MB1928FE8EC4E862B1FF2F9BAE91740-GXldUsIPo7Z/SeJcUcAJq43W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-05-13 9:06 ` Mark Brown
2016-05-13 3:08 ` Scott Wood
[not found] ` <DB5PR0401MB192850FBCBE79EBBC61ACA3A91740-GXldUsIPo7Z/SeJcUcAJq43W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-05-13 10:26 ` Mark Brown
2016-05-03 21:32 ` Li Yang
[not found] ` <CADRPPNQ8auFyiEmnWE=FgQ1WBi-GFjCGr5xHzq5d_KnnFQ6CUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-09 7:53 ` Yao Yuan
2016-04-27 8:12 ` [PATCH 2/2] spi: spi-fsl-dspi: Update DT binding documentation Yuan Yao
[not found] ` <1461744756-31481-3-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2016-04-27 16:35 ` Applied "spi: spi-fsl-dspi: Update DT binding documentation" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512163131.GF6261@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=leoyang.li-3arQi8VN3Tc@public.gmane.org \
--cc=linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=scott.wood-3arQi8VN3Tc@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yao.yuan-3arQi8VN3Tc@public.gmane.org \
--cc=yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).