From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH 2/2] mtd: m25p80: consider max_transfer_size when reading Date: Mon, 6 Jun 2016 11:43:48 -0700 Message-ID: <20160606184348.GA135086@google.com> References: <20160405193952.GA5243@localhost> <57041B43.2000109@gmail.com> <20160405210727.GB5243@localhost> <5706B084.2070909@gmail.com> <20160505235700.GA99474@google.com> <20160506121431.GQ6292@sirena.org.uk> <77a22258-95ca-031a-825d-a9e98e30a162@gmail.com> <20160606174003.GE7510@sirena.org.uk> <20160606182803.GA128439@google.com> <20160606183426.GJ7510@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Heiner Kallweit , Michal Suchanek , MTD Maling List , Cyrille Pitchen , Marek Vasut , Han Xu , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Return-path: Content-Disposition: inline In-Reply-To: <20160606183426.GJ7510-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Mon, Jun 06, 2016 at 07:34:26PM +0100, Mark Brown wrote: > On Mon, Jun 06, 2016 at 11:28:03AM -0700, Brian Norris wrote: > > On Mon, Jun 06, 2016 at 06:40:03PM +0100, Mark Brown wrote: > > > On Sat, Jun 04, 2016 at 12:22:37AM +0200, Heiner Kallweit wrote: > > > > > I'd like to come back to this discussion. You said best would be to fix > > > > the chip driver. To do this and calculate an appropriate value for > > > > max_transfer_size the chip driver would have to know that the spi_device > > > > is a spi-nor device. > > > > That doesn't make any sense, the controller hardware doesn't magically > > > change based on what is connected to it. > > > I believe Heiner has an (unstated here, but stated elsewhere?) > > assumption that his driver has a maximum *message* size, not *transfer* > > size. So he's explaining how to work around that by implicitly figuring > > out what the message size would be based on a transfer size, I think. > > That still wouldn't explain how this could depend on the connected > device, the message size isn't going to change any more than the > transfer size is. Ah, well I bet Heiner's mostly just testing flash (m25p80) and/or m25p80 is one of the bigger stressors. Anyway, you're definitely correct that Heiner's suggested approach is not good. He's essentially implying his driver should be intuiting the message size / transfer size patterns for arbitrary users. I suppose we really just need to figure out what his actual problem is, so we can address it generically. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html