linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jarkko Nikula
	<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RESEND] spi: spidev: Allow matching DT compatible strings from ACPI
Date: Tue, 28 Jun 2016 12:22:34 +0300	[thread overview]
Message-ID: <20160628092234.GG1711@lahna.fi.intel.com> (raw)
In-Reply-To: <20160627122448.GU28202-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Mon, Jun 27, 2016 at 01:24:48PM +0100, Mark Brown wrote:
> On Mon, Jun 27, 2016 at 02:34:08PM +0300, Mika Westerberg wrote:
> 
> > Allow the same devices to be used in ACPI based systems if they provide
> > proper DT compatible string.
> 
> Please allow a reasonable time for review, especially for an invasive
> change like this which needs a bunch of research to figure out how
> sensible the infrastructure to shove DT into ACPI is.

Sure.

Can I ask your opinion regarding an alternative approach to this?

Instead of adding these "pseudo", Linux specific devices to DT or ACPI
to support raw SPI access, what if we amend spidev a bit:

  - Introduce CONFIG_SPI_SPIDEV_MASTER which is part of spidev.c
    and can be selected separately.

  - If that option is set we create /dev/spi-<bus_num> for each SPI
    master.

  - Introduce two new ioctls SPI_IOC_RD/WR_CS which allow setting
    of chip select.

The /dev/spi-0 then can be used analogous to /dev/i2c-0. You first need
to program wanted chip select using those new ioctls. Then you can use
the device as normal spidev (all existing file operations and ioctls
still work). You can pick another chip select as needed. If there is an
actual SPI device bound to a chip select, that cannot be used through
/dev/spi-0.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-06-28  9:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 11:34 [PATCH RESEND] spi: spidev: Allow matching DT compatible strings from ACPI Mika Westerberg
     [not found] ` <1467027248-6191-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-06-27 12:24   ` Mark Brown
     [not found]     ` <20160627122448.GU28202-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-28  9:22       ` Mika Westerberg [this message]
     [not found]         ` <20160628092234.GG1711-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-06-28 11:47           ` Mark Brown
     [not found]             ` <20160628114742.GM17217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-28 14:35               ` Mika Westerberg
     [not found]                 ` <20160628143528.GK1711-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-06-28 15:07                   ` Mark Brown
     [not found]                     ` <20160628150752.GO17217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-28 15:23                       ` Mika Westerberg
     [not found]                         ` <20160628152338.GN1711-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-06-28 16:18                           ` Mark Brown
     [not found]                             ` <20160628161822.GQ17217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-29  9:13                               ` Mika Westerberg
     [not found]                                 ` <20160629091304.GP1711-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-06-29 16:21                                   ` Mark Brown
     [not found]                                     ` <20160629162127.GA6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-29 16:34                                       ` Mika Westerberg
     [not found]                                         ` <20160629163420.GC1711-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-06-29 18:31                                           ` Mark Brown
     [not found]                                             ` <20160629183101.GN6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-29 18:51                                               ` Mika Westerberg
     [not found]                                                 ` <20160629185155.GG1711-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-06-29 19:20                                                   ` Mark Brown
     [not found]                                                     ` <20160629192059.GV6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-30 12:49                                                       ` Mika Westerberg
     [not found]                                                         ` <20160630124931.GD23527-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-07-01 10:12                                                           ` Mark Brown
2016-07-01 10:19                                                           ` Mika Westerberg
     [not found]                                                             ` <20160701101912.GL23527-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-07-01 14:50                                                               ` Mark Brown
     [not found]                                                                 ` <20160701145035.GP6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-02  9:01                                                                   ` Mika Westerberg
     [not found]                                                                     ` <20160702090114.GS23527-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-07-02 10:15                                                                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628092234.GG1711@lahna.fi.intel.com \
    --to=mika.westerberg-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).