From: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jarkko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH] spi: spidev: Add ACPI probing support
Date: Mon, 4 Jul 2016 16:27:36 +0300 [thread overview]
Message-ID: <20160704132736.GD23527@lahna.fi.intel.com> (raw)
In-Reply-To: <20160704132048.GC6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Mon, Jul 04, 2016 at 03:20:48PM +0200, Mark Brown wrote:
> On Mon, Jul 04, 2016 at 04:08:06PM +0300, Mika Westerberg wrote:
> > On Mon, Jul 04, 2016 at 02:56:00PM +0200, Mark Brown wrote:
>
> > > This is fine for now since all the ACPI devices are dummy ones but as
> > > soon as someone comes up with an actual ACPI ID for something that
> > > should be managed via spidev it'll need changing...
>
> > Sure. That's why the comment above also mentions SPT000* there.
>
> I'm trying to suggest that it'd be nice to write the code to check the
> IDs and only warns when appropriate. :)
Ah right, got it now.
I'll update the patch then to check the IDs first.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-04 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 10:38 [PATCH] spi: spidev: Add ACPI probing support Mika Westerberg
[not found] ` <1467628683-5783-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-07-04 12:56 ` Mark Brown
[not found] ` <20160704125600.GB6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-04 13:08 ` Mika Westerberg
[not found] ` <20160704130806.GB23527-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-07-04 13:20 ` Mark Brown
[not found] ` <20160704132048.GC6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-04 13:27 ` Mika Westerberg [this message]
[not found] ` <20160704132736.GD23527-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-07-04 13:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704132736.GD23527@lahna.fi.intel.com \
--to=mika.westerberg-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).