From: Matt Fleming <matt@codeblueprint.co.uk>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Mark Brown <broonie@kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Joel Becker <jlbec@evilplan.org>,
linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, irina.tirdea@intel.com,
leonard.crestez@intel.com, geert@linux-m68k.org
Subject: Re: [PATCH v6 6/8] efi: load SSTDs from EFI variables
Date: Wed, 6 Jul 2016 12:58:27 +0100 [thread overview]
Message-ID: <20160706115827.GR8415@codeblueprint.co.uk> (raw)
In-Reply-To: <1467713392-24825-1-git-send-email-octavian.purdila@intel.com>
On Tue, 05 Jul, at 01:09:52PM, Octavian Purdila wrote:
> This patch allows SSDTs to be loaded from EFI variables. It works by
> specifying the EFI variable name containing the SSDT to be loaded. All
> variables with the same name (regardless of the vendor GUID) will be
> loaded.
>
> Note that we can't use acpi_install_table and we must rely on the
> dynamic ACPI table loading and bus re-scanning mechanisms. That is
> because I2C/SPI controllers are initialized earlier then the EFI
> subsystems and all I2C/SPI ACPI devices are enumerated when the
> I2C/SPI controllers are initialized.
>
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
> ---
>
> As the rest of the series remains unchanged and it got Acks from most
> of the other patches, I've resend only this patch. Rafael, please let
> me know if you prefer to resend the whole series.
>
> Changes from v5:
>
> * enable duplicate detection to avoid firmware bugs that returns the
> same variable over and over again; this requires pushing the entry
> allocation back into efivar_ssdt_iter() and creating a temporary list
> that is iterated over in efivar_ssdt_load()
>
> * marked efivar_ssdt with __initdata
>
>
> Documentation/acpi/ssdt-overlays.txt | 67 +++++++++++++++++++++++++
> Documentation/kernel-parameters.txt | 7 +++
> drivers/firmware/efi/efi.c | 96 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 170 insertions(+)
Looks fine to me. Thanks Octavian.
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
prev parent reply other threads:[~2016-07-06 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 10:09 [PATCH v6 6/8] efi: load SSTDs from EFI variables Octavian Purdila
2016-07-06 11:58 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706115827.GR8415@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=irina.tirdea@intel.com \
--cc=jlbec@evilplan.org \
--cc=lenb@kernel.org \
--cc=leonard.crestez@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).