From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Shyti Subject: Re: [PATCH -next] spi: s3c64xx: fix reference leak to master in s3c64xx_spi_remove() Date: Wed, 13 Jul 2016 18:17:56 +0900 Message-ID: <20160713091756.GL18237@samsunx.samsung> References: <1468321722-16568-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Kukjin Kim , Krzysztof Kozlowski , Mark Brown , Wei Yongjun , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org To: weiyj_lk@163.com Return-path: Content-disposition: inline In-reply-to: <1468321722-16568-1-git-send-email-weiyj_lk@163.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Tue, Jul 12, 2016 at 11:08:42AM +0000, weiyj_lk@163.com wrote: > From: Wei Yongjun > > Once a spi_master_get() call succeeds, we need an additional > spi_master_put() call to free the memory, otherwise we will > leak a reference to master. Fix by removing the unnecessary > spi_master_get() call. > > Signed-off-by: Wei Yongjun After our discussion, I checked it again and feel free to add Reviewed-by: Andi Shyti Thanks, Andi > --- > drivers/spi/spi-s3c64xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index df88fa1..001c9eb 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -1211,7 +1211,7 @@ err0: > > static int s3c64xx_spi_remove(struct platform_device *pdev) > { > - struct spi_master *master = spi_master_get(platform_get_drvdata(pdev)); > + struct spi_master *master = platform_get_drvdata(pdev); > struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master); > > pm_runtime_get_sync(&pdev->dev); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >