From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jayachandran C <jchandra-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 2/2] spi: xlp: Add ACPI support for Vulcan SPI controller
Date: Mon, 8 Aug 2016 14:14:08 +0100 [thread overview]
Message-ID: <20160808131408.GE10383@sirena.org.uk> (raw)
In-Reply-To: <1470658708-8203-2-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Mon, Aug 08, 2016 at 05:48:28PM +0530, kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org wrote:
> - if (IS_ERR(clk)) {
> - dev_err(&pdev->dev, "could not get spi clock\n");
> - return -ENODEV;
> - }
> + if (IS_ERR(clk))
> + return -EPROBE_DEFER;
> +
No, this is broken - if there really is a fatal error it'll silently
discard it and replace it with -EPROBE_DEFER. This will cause things to
be incorrectly deferred if there is a real error making it harder for
people to diagnose problems. You should just pass the error code you
get back to the caller.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-08 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 12:18 [PATCH 1/2] ACPI / APD: Add device HID for Vulcan SPI controller kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
[not found] ` <1470658708-8203-1-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-08-08 12:18 ` [PATCH 2/2] spi: xlp: Add ACPI support " kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
[not found] ` <1470658708-8203-2-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-08-08 13:14 ` Mark Brown [this message]
2016-08-08 13:14 ` [PATCH 1/2] ACPI / APD: Add device HID " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808131408.GE10383@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=jchandra-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).