From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH] spi: qup: skip clk_disable_unprepare if the device is already runtime suspended Date: Thu, 25 Aug 2016 08:26:06 -0500 Message-ID: <20160825132606.GA24683@hector.attlocal.net> References: <1472128408-7231-1-git-send-email-sudeep.holla@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Brown , Mark Brown To: Sudeep Holla Return-path: Content-Disposition: inline In-Reply-To: <1472128408-7231-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, Aug 25, 2016 at 01:33:28PM +0100, Sudeep Holla wrote: > If the spi device is already runtime suspended, if spi_qup_suspend is > executed during suspend-to-idle or suspend-to-ram it will result in the > following splat: > > WARNING: CPU: 3 PID: 1593 at drivers/clk/clk.c:476 clk_core_unprepare+0x80/0x90 > Modules linked in: > Thanks for fixing this. I had noticed this yesterday when I was testing your freeze patch but hadn't had time to dig in. Tested-by: Andy Gross -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html