From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/1] spi: sc18is602: Add reset control via gpio pin.
Date: Wed, 31 Aug 2016 15:49:34 +0100 [thread overview]
Message-ID: <20160831144934.GA5967@sirena.org.uk> (raw)
In-Reply-To: <1472628698-10599-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Wed, Aug 31, 2016 at 03:31:37PM +0800, Phil Reid wrote:
> I didn't not check for null on devm_gpiod_get_optional as gpiod_set_value
> does this on entry. Frequency of this seemed low enough that the function
> call doesn't add any significant overhead. I can add a check if required.
Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-31 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 7:31 [PATCH 0/1] spi: sc18is602: Add reset control via gpio pin Phil Reid
[not found] ` <1472628698-10599-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2016-08-31 7:31 ` [PATCH 1/1] " Phil Reid
[not found] ` <1472628698-10599-2-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2016-09-01 20:35 ` Applied "spi: sc18is602: Add reset control via gpio pin." to the spi tree Mark Brown
2016-08-31 14:49 ` Mark Brown [this message]
[not found] ` <20160831144934.GA5967-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-01 1:47 ` [PATCH 0/1] spi: sc18is602: Add reset control via gpio pin Phil Reid
[not found] ` <fecfdf07-a3e6-c84d-31dc-b1e2b7486868-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2016-09-01 10:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831144934.GA5967@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).