From: Matthias Seidel <kernel-NoMTM8u0nx3R7s880joybQ@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 2/2] spi: dw: round up result of calculation for clock divider
Date: Sun, 4 Sep 2016 02:05:35 +0200 [thread overview]
Message-ID: <20160904020535.2bb2ab68@vm> (raw)
Avoid ending up with a higher frequency than requested
Signed-off-by: Matthias Seidel <kernel-NoMTM8u0nx3R7s880joybQ@public.gmane.org>
---
Previously failing example:
requested transfer freq: 16MHz
max_freq = 200MHz
calculated clk_div = 12
actual frequency = 200/12 = 16.6666MHz
---
drivers/spi/spi-dw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
index c85e4b3..2fd517d 100644
--- a/drivers/spi/spi-dw.c
+++ b/drivers/spi/spi-dw.c
@@ -300,7 +300,8 @@ static int dw_spi_transfer_one(struct spi_master *master,
if (transfer->speed_hz != dws->current_freq) {
if (transfer->speed_hz != chip->speed_hz) {
/* clk_div doesn't support odd number */
- chip->clk_div = (dws->max_freq / transfer->speed_hz + 1) & 0xfffe;
+ chip->clk_div = ((dws->max_freq + transfer->speed_hz) /
+ transfer->speed_hz + 1) & 0xfffe;
chip->speed_hz = transfer->speed_hz;
}
dws->current_freq = transfer->speed_hz;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2016-09-04 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 0:05 Matthias Seidel [this message]
2016-09-06 10:53 ` [PATCH v2 2/2] spi: dw: round up result of calculation for clock divider Mark Brown
[not found] ` <20160906105352.GK3950-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-06 17:16 ` [PATCH v3 " Matthias Seidel
2016-09-06 22:21 ` Mark Brown
[not found] ` <20160906222131.GT3950-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-07 15:45 ` [PATCH v4] " Matthias Seidel
2016-09-12 19:08 ` Applied "spi: dw: round up result of calculation for clock divider" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160904020535.2bb2ab68@vm \
--to=kernel-nomtm8u0nx3r7s880joybq@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).