linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Milo Kim <woogyom.kim@gmail.com>
To: Mark Brown <broonie@kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Milo Kim <woogyom.kim@gmail.com>
Subject: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size
Date: Wed, 19 Oct 2016 23:02:34 +0900	[thread overview]
Message-ID: <20161019140234.13518-4-woogyom.kim@gmail.com> (raw)
In-Reply-To: <20161019140234.13518-1-woogyom.kim@gmail.com>

The argument can be removed because the driver private data has it.

Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
 drivers/spi/spi-sun6i.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index 91235b2..c638f5d 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -105,8 +105,9 @@ static inline void sun6i_spi_write(struct sun6i_spi *sspi, u32 reg, u32 value)
 	writel(value, sspi->base_addr + reg);
 }
 
-static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi, int len)
+static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi)
 {
+	int len = sspi->fifo_depth;
 	u32 reg, cnt;
 	u8 byte;
 
@@ -125,8 +126,9 @@ static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi, int len)
 	}
 }
 
-static inline void sun6i_spi_fill_fifo(struct sun6i_spi *sspi, int len)
+static inline void sun6i_spi_fill_fifo(struct sun6i_spi *sspi)
 {
+	int len = sspi->fifo_depth;
 	u8 byte;
 
 	if (len > sspi->len)
@@ -270,7 +272,7 @@ static int sun6i_spi_transfer_one(struct spi_master *master,
 			SUN6I_BURST_CTL_CNT_STC(tx_len));
 
 	/* Fill the TX FIFO */
-	sun6i_spi_fill_fifo(sspi, sspi->fifo_depth);
+	sun6i_spi_fill_fifo(sspi);
 
 	/* Enable the interrupts */
 	sun6i_spi_write(sspi, SUN6I_INT_CTL_REG, SUN6I_INT_CTL_TC);
@@ -293,7 +295,7 @@ static int sun6i_spi_transfer_one(struct spi_master *master,
 		goto out;
 	}
 
-	sun6i_spi_drain_fifo(sspi, sspi->fifo_depth);
+	sun6i_spi_drain_fifo(sspi);
 
 out:
 	sun6i_spi_write(sspi, SUN6I_INT_CTL_REG, 0);
-- 
2.9.3

  parent reply	other threads:[~2016-10-19 14:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 14:02 [PATCH 0/3] Support H3 SPI controller Milo Kim
2016-10-19 14:02 ` [PATCH 1/3] spi: sun6i: Add binding for Allwinner " Milo Kim
     [not found]   ` <20161019140234.13518-2-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-20 15:45     ` Maxime Ripard
2016-11-03 15:42   ` Applied "spi: sun6i: Add binding for Allwinner H3 SPI controller" to the spi tree Mark Brown
2016-10-19 14:02 ` [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Milo Kim
     [not found]   ` <20161019140234.13518-3-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-20 15:50     ` Maxime Ripard
2016-10-20 15:53     ` Chen-Yu Tsai
2016-10-21 13:36       ` Milo Kim
2016-10-19 14:02 ` Milo Kim [this message]
     [not found]   ` <20161019140234.13518-4-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-20 15:56     ` [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size Maxime Ripard
2016-10-21 13:39       ` Milo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161019140234.13518-4-woogyom.kim@gmail.com \
    --to=woogyom.kim@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).