linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-spi@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	festevam@gmail.com, Jiada Wang <jiada_wang@mentor.com>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH 5/6] spi: imx: remove bytes_per_word from private driver struct
Date: Fri,  2 Jun 2017 07:38:03 +0200	[thread overview]
Message-ID: <20170602053804.3238-6-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20170602053804.3238-1-s.hauer@pengutronix.de>

We already have bits_per_word in the private driver struct and
bytes_per_word can be calculated from it, so remove bits_per_word.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/spi/spi-imx.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 0ec8d816e033..12e5ef7beb0b 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -92,7 +92,6 @@ struct spi_imx_data {
 
 	unsigned int speed_hz;
 	unsigned int bits_per_word;
-	unsigned int bytes_per_word;
 	unsigned int spi_drctl;
 
 	unsigned int count;
@@ -215,9 +214,7 @@ static bool spi_imx_can_dma(struct spi_master *master, struct spi_device *spi,
 	if (!master->dma_rx)
 		return false;
 
-	bpw = transfer->bits_per_word;
-
-	bpw = spi_imx_bytes_per_word(bpw);
+	bpw = spi_imx_bytes_per_word(transfer->bits_per_word);
 
 	if (bpw != 1 && bpw != 2 && bpw != 4)
 		return false;
@@ -833,15 +830,14 @@ static irqreturn_t spi_imx_isr(int irq, void *dev_id)
 	return IRQ_HANDLED;
 }
 
-static int spi_imx_dma_configure(struct spi_master *master,
-				 int bytes_per_word)
+static int spi_imx_dma_configure(struct spi_master *master)
 {
 	int ret;
 	enum dma_slave_buswidth buswidth;
 	struct dma_slave_config rx = {}, tx = {};
 	struct spi_imx_data *spi_imx = spi_master_get_devdata(master);
 
-	switch (bytes_per_word) {
+	switch (spi_imx_bytes_per_word(spi_imx->bits_per_word)) {
 	case 4:
 		buswidth = DMA_SLAVE_BUSWIDTH_4_BYTES;
 		break;
@@ -875,8 +871,6 @@ static int spi_imx_dma_configure(struct spi_master *master,
 		return ret;
 	}
 
-	spi_imx->bytes_per_word = bytes_per_word;
-
 	return 0;
 }
 
@@ -910,8 +904,7 @@ static int spi_imx_setupxfer(struct spi_device *spi,
 		spi_imx->usedma = 0;
 
 	if (spi_imx->usedma) {
-		ret = spi_imx_dma_configure(spi->master,
-					    spi_imx_bytes_per_word(spi_imx->bits_per_word));
+		ret = spi_imx_dma_configure(spi->master);
 		if (ret)
 			return ret;
 	}
-- 
2.11.0

  parent reply	other threads:[~2017-06-02  5:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02  5:37 spi: i.MX: Some cleanup patches Sascha Hauer
     [not found] ` <20170602053804.3238-1-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-06-02  5:37   ` [PATCH 1/6] spi: imx: Nothing to do in setupxfer when transfer is NULL Sascha Hauer
     [not found]     ` <20170602053804.3238-2-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-06-06 19:07       ` Applied "spi: imx: Nothing to do in setupxfer when transfer is NULL" to the spi tree Mark Brown
2017-06-02  5:38   ` [PATCH 2/6] spi: imx: Drop unnecessary check Sascha Hauer
2017-06-06 19:07     ` Applied "spi: imx: Drop unnecessary check" to the spi tree Mark Brown
2017-06-02  5:38   ` [PATCH 4/6] spi: imx: drop bogus unnecessary dma config Sascha Hauer
2017-06-06 19:07     ` Applied "spi: imx: drop bogus unnecessary dma config" to the spi tree Mark Brown
2017-06-02  5:38 ` [PATCH 3/6] spi: imx: put struct spi_imx_config members into driver private struct Sascha Hauer
2017-06-06 19:07   ` Applied "spi: imx: put struct spi_imx_config members into driver private struct" to the spi tree Mark Brown
2017-06-02  5:38 ` Sascha Hauer [this message]
2017-06-06 19:07   ` Applied "spi: imx: remove bytes_per_word from private driver " Mark Brown
2017-06-02  5:38 ` [PATCH 6/6] spi: imx: rename 'bpw' variables Sascha Hauer
     [not found]   ` <20170602053804.3238-7-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-06-06 19:07     ` Applied "spi: imx: rename 'bpw' variables" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602053804.3238-6-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=jiada_wang@mentor.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).