linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Amelie DELAUNAY <amelie.delaunay@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list
Date: Fri, 30 Jun 2017 12:51:50 +0100	[thread overview]
Message-ID: <20170630115150.zea5iaoih4alqibm@sirena.org.uk> (raw)
In-Reply-To: <67764839-889b-e398-16eb-de583d82cbf3@st.com>

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

On Thu, Jun 29, 2017 at 02:58:43PM +0200, Amelie DELAUNAY wrote:
> On 06/28/2017 08:54 PM, Mark Brown wrote:

> > What does this device actually do and why is spidev a sensible fit for
> > it?

> This device is actually a debugging tool [1] which can work on SPI bus (and
> also I2C). Connected via USB on a PC, it can either acts as an SPI master or
> SPI slave and it can transmit/receive serial data using SPI protocol.
> Polarity, Phase, Bit Order, Frequency can be configured. So this tool is
> really useful during SPI driver development to troubleshoot. And that's why
> spidev driver totally fit for it when used as an SPI slave, for the reason
> described in spidev Documentation: "Developing simple protocols used to talk
> to" Aardvark "acting as SPI slaves, which you may need to change quite
> often".

This doesn't seem like something that should be in DT, it's a tool used
to implement or emulate other things and is no more specific than spidev
itself is.  Whatever it is implementing or emulating should be in DT
instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2017-06-30 11:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 15:45 [PATCHv2 0/9] STM32 SPI various fixes Amelie Delaunay
     [not found] ` <1498578321-13980-1-git-send-email-amelie.delaunay-qxv4g6HH51o@public.gmane.org>
2017-06-27 15:45   ` [PATCHv2 1/9] dt-bindings: spi: stm32: use SoC specific compatible Amelie Delaunay
     [not found]     ` <1498578321-13980-2-git-send-email-amelie.delaunay-qxv4g6HH51o@public.gmane.org>
2017-06-28 18:51       ` Mark Brown
2017-06-27 15:45   ` [PATCHv2 2/9] spi: stm32: fix compatible to fit with new bindings Amelie Delaunay
2017-06-27 15:45   ` [PATCHv2 3/9] dt-bindings: spi: stm32: fix example with st,spi-midi-ns property Amelie Delaunay
2017-06-28 19:25     ` Applied "spi: stm32: fix example with st, spi-midi-ns property" to the spi tree Mark Brown
2017-06-27 15:45   ` [PATCHv2 6/9] spi: stm32: add runtime PM support Amelie Delaunay
2017-06-27 15:45   ` [PATCHv2 7/9] spi: stm32: enhance DMA error management Amelie Delaunay
     [not found]     ` <1498578321-13980-8-git-send-email-amelie.delaunay-qxv4g6HH51o@public.gmane.org>
2017-06-28 19:25       ` Applied "spi: stm32: enhance DMA error management" to the spi tree Mark Brown
2017-06-27 15:45   ` [PATCHv2 8/9] spi: stm32: fix potential dereference null return value Amelie Delaunay
2017-06-27 15:45 ` [PATCHv2 4/9] spi: stm32: replace st, spi-midi with st, spi-midi-ns to fit bindings Amelie Delaunay
2017-06-27 15:45 ` [PATCHv2 5/9] spi: stm32: use normal conditional statements instead of ternary operator Amelie Delaunay
2017-06-27 15:45 ` [PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list Amelie Delaunay
     [not found]   ` <1498578321-13980-10-git-send-email-amelie.delaunay-qxv4g6HH51o@public.gmane.org>
2017-06-28 18:54     ` Mark Brown
2017-06-29 12:58       ` Amelie DELAUNAY
2017-06-30 11:51         ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170630115150.zea5iaoih4alqibm@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=amelie.delaunay@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).