From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v1] spi: pxa2xx: Don't touch CS pin until we have a transfer pending Date: Fri, 28 Jul 2017 13:51:42 +0300 Message-ID: <20170728105142.GN2369@lahna.fi.intel.com> References: <20170727154933.14143-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Brown , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko Return-path: Content-Disposition: inline In-Reply-To: <20170727154933.14143-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, Jul 27, 2017 at 06:49:33PM +0300, Andy Shevchenko wrote: > GPIO descriptors, when being requested, may configure pin at the same > time. In case of SPI chip select we shouldn't do any assumptions of the > state of pin since we don't know yet what chip is connected there and if > it uses high or low active state. So, leave the state of pin as is until > transfer will start. > > Fixes: 99f499cd6504 ("spi: pxa2xx: Add support for GPIO descriptor chip selects") > Cc: Mika Westerberg Yes, I think this is the right thing to do, Acked-by: Mika Westeberg -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html