From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible Date: Fri, 4 Aug 2017 13:24:08 +0300 Message-ID: <20170804102408.GX2369@lahna.fi.intel.com> References: <6bfd2b29b888c14f1a6feb9dee5bb54b74e761b0.1501760433.git.jan.kiszka@siemens.com> <20170804101029.GV2369@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Brown , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Andy Shevchenko , linux-spi , Linux Kernel Mailing List , linux-arm-kernel To: Jan Kiszka Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Fri, Aug 04, 2017 at 12:18:28PM +0200, Jan Kiszka wrote: > On 2017-08-04 12:10, Mika Westerberg wrote: > > On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> We still need to request/free GPIOs passed via the legacy path of > >> pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise. > >> > >> Consistently use the descriptor API instead of the legacy one. > >> > >> Signed-off-by: Jan Kiszka > > > > There are some PXA2xx platforms under arch/arm/* which use this driver > > and legacy GPIOs. I wonder if this causes any problems with them? > > > > That was one of the reasons I did not convert the whole driver over GPIO > > descriptors. > > It shouldn't cause problems (famous last words) because I refrained from > changing the interfaces to them. References that come in as legacy GPIO > are still treated like that. OK. I hope someone with a PXA2xx machine could still test it. Acked-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html