From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org
Cc: linux-rpi-kernel
<linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: spi->irq == 0 on module reload of driver using IRQF_TRIGGER_LOW
Date: Sun, 12 Nov 2017 19:19:30 +0100 [thread overview]
Message-ID: <20171112181930.GG30830@lunn.ch> (raw)
In-Reply-To: <20171112154101.483d21d2-Fmn/x+r+pSA9//JtdbceeD8Kkb2uy4ct@public.gmane.org>
> > +&spi {
> > + status = "okay";
> > +
> > + can0: mcp2517fd@0 {
> > + reg = <0>;
> > + compatible = "microchip,mcp2517fd";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&can0_pins>;
> > + spi-max-frequency = <12500000>;
> > + interrupt-parent = <&gpio>;
> > + interrupts = <16 0x2>;
>
> This indicates a falling edge. No wonder the kernel is confused (I
> don't know why this isn't enforced the first time though, probably an
> issue in the GPIO irqchip driver...). Replacing this 2 with a 8 should
> allow you to make some progress.
And using IRQ_TYPE_LEVEL_LOW, from interrupt-controller/irq.h would
make it readable.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-11-12 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 12:32 spi->irq == 0 on module reload of driver using IRQF_TRIGGER_LOW kernel-TqfNSX0MhmxHKSADF0wUEw
[not found] ` <21FDD1B8-E8F6-4DCE-9D30-D82B713B0008-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2017-11-12 14:13 ` Marc Zyngier
[not found] ` <20171112141349.6b4b3852-Fmn/x+r+pSA9//JtdbceeD8Kkb2uy4ct@public.gmane.org>
2017-11-12 15:13 ` kernel-TqfNSX0MhmxHKSADF0wUEw
[not found] ` <CD4EBEF8-DDFD-40C3-A03E-7EC964B32357-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2017-11-12 15:41 ` Marc Zyngier
[not found] ` <20171112154101.483d21d2-Fmn/x+r+pSA9//JtdbceeD8Kkb2uy4ct@public.gmane.org>
2017-11-12 16:49 ` kernel-TqfNSX0MhmxHKSADF0wUEw
[not found] ` <6CD8E928-2143-4295-A5B3-4B95026E7261-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2017-11-13 9:35 ` Marc Zyngier
[not found] ` <87k1yuttaa.fsf-vRCh2aeoaAgb5lhT7GhwOB/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2017-11-13 18:25 ` kernel-TqfNSX0MhmxHKSADF0wUEw
2017-11-12 18:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171112181930.GG30830@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).