linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Trent Piepho <tpiepho@impinj.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v4 3/3] ARM: imx: Update spi_imx platform data to reflect current state
Date: Thu, 16 Nov 2017 15:47:44 +0800	[thread overview]
Message-ID: <20171116074743.GC25384@dragon> (raw)
In-Reply-To: <20171106194618.9421-4-tpiepho@impinj.com>

On Mon, Nov 06, 2017 at 11:46:18AM -0800, Trent Piepho wrote:
> The docs for the spi_imx platform data still refer to a -32 offset used to
> specify a native chip select.  This was removed in commit 602c8f4485cd
> ("spi: imx: fix use of native chip-selects with devicetree") and no
> longer works as documented.  Update documentation.
> 
> The macro MXC_SPI_CS() is no longer is needed.
> 
> If a board uses all native chip selects, then it's not necessary to
> specify a chip select array at all, as all native is the default (this is
> how device-tree configured SPI masters work too).  Most of the spi-imx
> platform data users have their chip select arrays removed by this patch.
> 
> This patch also fixes a bug in mx31moboard introduced in the '602 commit.
> When that board was updated in commit 901f26bce64a ("ARM: imx: set
> correct chip_select in platform setup") to reflect the SPI change, only
> SPI bus 2 was updated and SPI bus 1 was left with non-sequential chip
> selects.  The mc13783 spi device on bus 1 had its chip select updated as
> if it were on bus 2.
> 
> CC: Shawn Guo <shawnguo@kernel.org>

Acked-by: Shawn Guo <shawnguo@kernel.org>

      parent reply	other threads:[~2017-11-16  7:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 19:46 [PATCH v4 0/3] Fix for imx-spi CS GPIOs Trent Piepho
     [not found] ` <20171106194618.9421-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-06 19:46   ` [PATCH v4 1/3] spi: imx: GPIO chip select DT property should not be required Trent Piepho
     [not found]     ` <20171106194618.9421-2-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-07  6:45       ` Oleksij Rempel
2017-11-08 19:26       ` Mark Brown
2017-11-06 19:46   ` [PATCH v4 2/3] spi: imx: Don't require platform data chipselect array Trent Piepho
     [not found]     ` <20171106194618.9421-3-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-07  6:58       ` Oleksij Rempel
2017-11-06 19:46   ` [PATCH v4 3/3] ARM: imx: Update spi_imx platform data to reflect current state Trent Piepho
     [not found]     ` <20171106194618.9421-4-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-07  7:03       ` Oleksij Rempel
2017-11-16  7:47     ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116074743.GC25384@dragon \
    --to=shawnguo@kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=tpiepho@impinj.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).