linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michele Dionisio <michele.dionisio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Michele Dionisio
	<michele.dionisio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: spi: davinci: Initialize dspi->done before any possible use of it
Date: Tue, 12 Dec 2017 11:36:59 +0100	[thread overview]
Message-ID: <20171212103659.23116-1-michele.dionisio@gmail.com> (raw)
In-Reply-To: <20171212101630.GB16323-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On SOC with multiple cpu (like omal l138) it is possible that spi
periferic is already initialized when this module is loaded and so
it is possible to recieve interrupt when the modules is not fully
initialized.

this patch initialize dspi->done before refister the interrupt
handler that use it

Signed-off-by: Michele Dionisio <michele.dionisio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 6ddb6ef1fda4..60d59b003aa4 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -945,6 +945,8 @@ static int davinci_spi_probe(struct platform_device *pdev)
 		goto free_master;
 	}
 
+	init_completion(&dspi->done);
+
 	ret = platform_get_irq(pdev, 0);
 	if (ret == 0)
 		ret = -EINVAL;
@@ -1021,8 +1023,6 @@ static int davinci_spi_probe(struct platform_device *pdev)
 	dspi->get_rx = davinci_spi_rx_buf_u8;
 	dspi->get_tx = davinci_spi_tx_buf_u8;
 
-	init_completion(&dspi->done);
-
 	/* Reset In/OUT SPI module */
 	iowrite32(0, dspi->base + SPIGCR0);
 	udelay(100);
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-12-12 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 10:10 spi: davinci: Initialize dspi->done before any possible use of it Michele Dionisio
     [not found] ` <20171212101048.28278-1-michele.dionisio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 10:10   ` Michele Dionisio
     [not found]     ` <20171212101048.28278-2-michele.dionisio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 11:17       ` Applied "spi: davinci: Initialize dspi->done before any possible use of it" to the spi tree Mark Brown
2017-12-12 10:16   ` spi: davinci: Initialize dspi->done before any possible use of it Mark Brown
     [not found]     ` <20171212101630.GB16323-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-12-12 10:36       ` Michele Dionisio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212103659.23116-1-michele.dionisio@gmail.com \
    --to=michele.dionisio-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).