From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kyle Roeschley <kyle.roeschley@ni.com>,
Trent Piepho <tpiepho@impinj.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: Add a sysfs interface to instantiate devices
Date: Wed, 27 Dec 2017 10:31:15 +0000 [thread overview]
Message-ID: <20171227103115.GP1827@finisterre> (raw)
In-Reply-To: <CAMuHMdVmNv8Pji0pGGS8L0Q0Rcp8FjCW3Y8NSMdGU3OHjJTNhw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
On Sat, Dec 23, 2017 at 09:58:51AM +0100, Geert Uytterhoeven wrote:
> >> > > + struct spi_board_info bi = {
> >> > > + .modalias = "spidev",
> I would make it a little bit more generic and extract the modalias from the
> string written.
Right, that'd be much better.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2017-12-27 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 20:03 [PATCH] spi: Add a sysfs interface to instantiate devices Kyle Roeschley
[not found] ` <20171221200309.17967-1-kyle.roeschley-acOepvfBmUk@public.gmane.org>
2017-12-21 20:11 ` Randy Dunlap
2017-12-21 21:05 ` Trent Piepho
[not found] ` <1513890342.26695.4.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-12-22 15:56 ` Mark Brown
2017-12-22 17:11 ` Kyle Roeschley
2017-12-23 8:58 ` Geert Uytterhoeven
2017-12-27 10:31 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227103115.GP1827@finisterre \
--to=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=kyle.roeschley@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).