From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Jan Kundrát" <jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
Chris Packham
<Chris.Packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>,
Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Christophe JAILLET
<christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org>,
Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>,
Grygorii Strashko
<grygorii.strashko-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 4/4] spi: orion: Software control for inter-word delays
Date: Thu, 15 Feb 2018 15:19:07 +0000 [thread overview]
Message-ID: <20180215151907.GD8374@sirena.org.uk> (raw)
In-Reply-To: <475b63c52b17187089d3f2ecf8ff4b8c45a7e58b.1518704854.git.jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Sat, Feb 10, 2018 at 01:25:32PM +0100, Jan Kundrát wrote:
> Add a SW-controlled timer for inserting delays between individual words
> as transmitted over the SPI bus. The DT property name is loosely
> modelled after a similar, but HW-based feature in spi-davinci.c (commit
> 365a7bb32e09) -- hence the DT property name.
I think this is a sensible and reasonable thing to want to do however I
think we should move this from a DT property to being something in the
transfer structure which drivers then implement. That way if a device
has an inter-word delay requirement it can go in the individual device
driver so it always gets applied. Does that make sense to you?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-02-15 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 14:15 [PATCH 1/4] spi: orion: Make the error message greppable Jan Kundrát
[not found] ` <bc8bf712358fbb000ea7e2ea9e1aec42b21988e6.1518704854.git.jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-10 11:20 ` [PATCH 3/4] spi: orion: Prepare space for per-child options Jan Kundrát
2018-02-10 12:25 ` [PATCH 4/4] spi: orion: Software control for inter-word delays Jan Kundrát
[not found] ` <475b63c52b17187089d3f2ecf8ff4b8c45a7e58b.1518704854.git.jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-15 15:19 ` Mark Brown [this message]
[not found] ` <20180215151907.GD8374-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-15 15:45 ` Jan Kundrát
[not found] ` <c5d27950-0d13-422c-afe9-990b4adad45a-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-15 15:49 ` Mark Brown
[not found] ` <20180215154945.GF8374-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-15 17:18 ` Trent Piepho
[not found] ` <1518715087.25567.68.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2018-02-15 17:29 ` Mark Brown
2018-02-15 14:19 ` [PATCH 2/4] spi: orion: Respect per-transfer bits_per_word settings Jan Kundrát
[not found] ` <b983963f1ad0400fdca2f8bf8095d25b62b0ffb0.1518704854.git.jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org>
2018-02-15 17:13 ` Trent Piepho
[not found] ` <E1emNJK-0004YS-Oj@debutante>
2018-02-15 17:36 ` Applied "spi: orion: Respect per-transfer bits_per_word settings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215151907.GD8374@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Chris.Packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=jan.kundrat-xoNZbkdr4U2lVyrhU4qvOw@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).