* [PATCH] spi: tegra20-slink: use true and false for boolean values
@ 2018-03-05 23:53 Gustavo A. R. Silva
2018-03-06 5:46 ` Laxman Dewangan
2018-03-08 13:14 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-03-05 23:53 UTC (permalink / raw)
To: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter
Cc: linux-spi, linux-tegra, linux-kernel, Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/spi/spi-tegra20-slink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 3e12d5f..6f7b946b 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -276,10 +276,10 @@ static unsigned tegra_slink_calculate_curr_xfer_param(
tspi->bytes_per_word = DIV_ROUND_UP(bits_per_word, 8);
if (bits_per_word == 8 || bits_per_word == 16) {
- tspi->is_packed = 1;
+ tspi->is_packed = true;
tspi->words_per_32bit = 32/bits_per_word;
} else {
- tspi->is_packed = 0;
+ tspi->is_packed = false;
tspi->words_per_32bit = 1;
}
tspi->packed_size = tegra_slink_get_packed_size(tspi, t);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: tegra20-slink: use true and false for boolean values
2018-03-05 23:53 [PATCH] spi: tegra20-slink: use true and false for boolean values Gustavo A. R. Silva
@ 2018-03-06 5:46 ` Laxman Dewangan
2018-03-08 13:14 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2018-03-06 5:46 UTC (permalink / raw)
To: Gustavo A. R. Silva, Mark Brown, Thierry Reding, Jonathan Hunter
Cc: linux-spi, linux-tegra, linux-kernel, Gustavo A. R. Silva
On Tuesday 06 March 2018 05:23 AM, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: tegra20-slink: use true and false for boolean values
2018-03-05 23:53 [PATCH] spi: tegra20-slink: use true and false for boolean values Gustavo A. R. Silva
2018-03-06 5:46 ` Laxman Dewangan
@ 2018-03-08 13:14 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2018-03-08 13:14 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Laxman Dewangan, Mark Brown, Jonathan Hunter, linux-spi,
linux-tegra, linux-kernel, Gustavo A. R. Silva
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
On Mon, Mar 05, 2018 at 05:53:39PM -0600, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/spi/spi-tegra20-slink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-08 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-05 23:53 [PATCH] spi: tegra20-slink: use true and false for boolean values Gustavo A. R. Silva
2018-03-06 5:46 ` Laxman Dewangan
2018-03-08 13:14 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).