From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v5] ARM: imx: Update spi_imx platform data to reflect current state Date: Wed, 18 Apr 2018 11:12:00 +0800 Message-ID: <20180418031159.GR25429@dragon> References: <20180402200605.13050-1-tpiepho@impinj.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Fabio Estevam , Sascha Hauer , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org To: Trent Piepho Return-path: Content-Disposition: inline In-Reply-To: <20180402200605.13050-1-tpiepho@impinj.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On Mon, Apr 02, 2018 at 01:06:05PM -0700, Trent Piepho wrote: > The docs for the spi_imx platform data still refer to a -32 offset used to > specify a native chip select. This was removed in commit 602c8f4485cd > ("spi: imx: fix use of native chip-selects with devicetree") and no > longer works as documented. Update documentation. > > The macro MXC_SPI_CS() is no longer is needed. > > If a board uses all native chip selects, then it's not necessary to > specify a chip select array at all, as all native is the default (this is > how device-tree configured SPI masters work too). Most of the spi-imx > platform data users have their chip select arrays removed by this patch. > > This patch also fixes a bug in mx31moboard introduced in the '602 commit. > When that board was updated in commit 901f26bce64a ("ARM: imx: set > correct chip_select in platform setup") to reflect the SPI change, only > SPI bus 2 was updated and SPI bus 1 was left with non-sequential chip > selects. The mc13783 spi device on bus 1 had its chip select updated as > if it were on bus 2. > > CC: Shawn Guo > CC: Sascha Hauer > CC: Fabio Estevam > Acked-by: Greg Ungerer > Reviewed-by: Oleksij Rempel > Signed-off-by: Trent Piepho Applied, thanks.