From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Vignesh R <vigneshr@ti.com>
Cc: "Yogesh Gaur" <yogeshnarayan.gaur@nxp.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
"Richard Weinberger" <richard@nod.at>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-spi@vger.kernel.org, "Peter Pan" <peterpansjtu@gmail.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Frieder Schrempf" <frieder.schrempf@exceet.de>,
"Mark Brown" <broonie@kernel.org>,
linux-mtd@lists.infradead.org,
"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH v3 7/9] spi: ti-qspi: Implement the spi_mem interface
Date: Thu, 26 Apr 2018 11:28:55 +0200 [thread overview]
Message-ID: <20180426112855.46e0f3c0@bbrezillon> (raw)
In-Reply-To: <b13e1147-c168-1163-436d-5c3fadf70191@ti.com>
On Thu, 26 Apr 2018 14:40:41 +0530
Vignesh R <vigneshr@ti.com> wrote:
> > +static int ti_qspi_exec_mem_op(struct spi_mem *mem,
> > + const struct spi_mem_op *op)
> > +{
> > + struct ti_qspi *qspi = spi_master_get_devdata(mem->spi->master);
> > + u32 from = 0;
> > + int ret = 0;
> > +
> > + /* Only optimize read path. */
> > + if (!op->data.nbytes || op->data.dir != SPI_MEM_DATA_IN ||
> > + !op->addr.nbytes || op->addr.nbytes > 4)
> > + return -ENOTSUPP;
> > +
> > + /* Address exceeds MMIO window size, fall back to regular mode. */
> > + from = op->addr.val;
> > + if (from + op->data.nbytes > qspi->mmap_size)
> > + return -ENOTSUPP;
> > +
>
> qspi->mmap_size turns out to be 0 if qspi->rx_chan is not NULL
> (in other words when DMA is used)
> Could you squash below diff into this patch?
Will do.
Thanks,
Boris
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2018-04-26 9:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 18:35 [PATCH v3 0/9] spi: Extend the framework to generically support memory devices Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 1/9] spi: Expose spi_{map,unmap}_buf() for internal use Boris Brezillon
2018-04-23 18:05 ` Applied "spi: Expose spi_{map, unmap}_buf() for internal use" to the spi tree Mark Brown
2018-04-22 18:35 ` [PATCH v3 2/9] spi: Add an helper to flush the message queue Boris Brezillon
2018-04-23 18:05 ` Applied "spi: Add an helper to flush the message queue" to the spi tree Mark Brown
2018-04-22 18:35 ` [PATCH v3 3/9] spi: Extend the core to ease integration of SPI memory controllers Boris Brezillon
2018-04-23 21:53 ` Andy Shevchenko
2018-04-23 22:10 ` Boris Brezillon
2018-04-24 10:47 ` Mark Brown
2018-05-11 2:58 ` Applied "spi: Extend the core to ease integration of SPI memory controllers" to the spi tree Mark Brown
2018-04-22 18:35 ` [PATCH v3 4/9] spi: Make support for regular transfers optional when ->mem_ops != NULL Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 5/9] spi: bcm-qspi: Implement the spi_mem interface Boris Brezillon
2018-04-24 15:19 ` Kamal Dasu
2018-04-22 18:35 ` [PATCH v3 6/9] spi: bcm53xx: " Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 7/9] spi: ti-qspi: " Boris Brezillon
2018-04-26 9:10 ` Vignesh R
2018-04-26 9:28 ` Boris Brezillon [this message]
2018-04-22 18:35 ` [PATCH v3 8/9] mtd: spi-nor: Use the spi_mem_xx() API Boris Brezillon
2018-04-22 18:35 ` [PATCH v3 9/9] spi: Get rid of the spi_flash_read() API Boris Brezillon
2018-05-11 9:24 ` Boris Brezillon
2018-04-26 9:07 ` [PATCH v3 0/9] spi: Extend the framework to generically support memory devices Vignesh R
2018-04-26 9:27 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426112855.46e0f3c0@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@exceet.de \
--cc=kdasu.kdev@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=peterpansjtu@gmail.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).