From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v4 3/6] mfd: at91-usart: added mfd driver for usart Date: Tue, 29 May 2018 11:32:00 +0200 Message-ID: <20180529093200.GB4793@piout.net> References: <20180525171941.26766-1-radu.pirea@microchip.com> <20180525171941.26766-4-radu.pirea@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Mark Rutland , devicetree , Linux Kernel Mailing List , Richard Genoud , Greg Kroah-Hartman , Rob Herring , linux-spi , Mark Brown , "open list:SERIAL DRIVERS" , Radu Pirea , Lee Jones , linux-arm Mailing List To: Andy Shevchenko Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 28/05/2018 11:00:49+0300, Andy Shevchenko wrote: > On Fri, May 25, 2018 at 8:19 PM, Radu Pirea wrote: > > This mfd driver is just a wrapper over atmel_serial driver and > > spi-at91-usart driver. Selection of one of the drivers is based on a > > property from device tree. If the property is not specified, the default > > driver is atmel_serial. > > > + depends on OF > > What makes this driver OF specific? > > > + err = of_property_read_u32(np, "atmel,usart-mode", &opmode); > > Check unified device property API. > We don't care, this makes the driver OF specific and this is the correct thing to do. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com