* [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe
@ 2018-06-21 13:22 Gustavo A. R. Silva
2018-06-21 15:27 ` Esben Haabendal
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-06-21 13:22 UTC (permalink / raw)
To: Esben Haabendal, Mark Brown; +Cc: linux-spi, linux-kernel, Gustavo A. R. Silva
It seems that the proper structure field to use in this particular
case is *regmap_pushr* instead of regmap.
Addresses-Coverity-ID: 1470126 ("Copy-paste error")
Fixes: 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/spi/spi-fsl-dspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 1f85dcd..ff7456b 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
dev_err(&pdev->dev,
"failed to init pushr regmap: %ld\n",
PTR_ERR(dspi->regmap_pushr));
- ret = PTR_ERR(dspi->regmap);
+ ret = PTR_ERR(dspi->regmap_pushr);
goto out_master_put;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe
2018-06-21 13:22 [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe Gustavo A. R. Silva
@ 2018-06-21 15:27 ` Esben Haabendal
0 siblings, 0 replies; 2+ messages in thread
From: Esben Haabendal @ 2018-06-21 15:27 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Mark Brown, linux-spi, linux-kernel
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> It seems that the proper structure field to use in this particular
> case is *regmap_pushr* instead of regmap.
>
> Addresses-Coverity-ID: 1470126 ("Copy-paste error")
> Fixes: 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/spi/spi-fsl-dspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 1f85dcd..ff7456b 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
> dev_err(&pdev->dev,
> "failed to init pushr regmap: %ld\n",
> PTR_ERR(dspi->regmap_pushr));
> - ret = PTR_ERR(dspi->regmap);
> + ret = PTR_ERR(dspi->regmap_pushr);
> goto out_master_put;
> }
> }
Acked-by: Esben Haabendal <eha@deif.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-21 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-21 13:22 [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe Gustavo A. R. Silva
2018-06-21 15:27 ` Esben Haabendal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).