From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 03/11] spi: Add a driver for the Freescale/NXP QuadSPI controller Date: Tue, 26 Jun 2018 15:47:28 +0200 Message-ID: <20180626154728.16e94b58@bbrezillon> References: <1527686082-15142-1-git-send-email-frieder.schrempf@exceet.de> <1527686082-15142-4-git-send-email-frieder.schrempf@exceet.de> <4046ba78-b6c0-c09b-43e2-e3c2e550be9f@exceet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: Frieder Schrempf , "linux-mtd@lists.infradead.org" , Yogesh Narayan Gaur , "linux-spi@vger.kernel.org" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "marek.vasut@gmail.com" , "richard@nod.at" , "miquel.raynal@bootlin.com" , "broonie@kernel.org" , David Wolfe , Fabio Estevam , Prabhakar Kushwaha , Han Xu , "linux-kernel@vger.kernel.org" To: Andy Shevchenko Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org Hi Andy, On Tue, 26 Jun 2018 16:18:44 +0300 Andy Shevchenko wrote: > > > What is wrong? Some newlines are missing here between the MODULE_ macros, > > but in my original patch it seems correct. > > It should be like > > MODULE_FOO(...); > MODULE_BAR(...); > MODULE_BAZ(...); > > One macro — one line. It's not Frieder's fault, it's Yogesh mailer which messed-up the formatting. Just look at the original patch and you'll see.