From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 02/12] mtd: m25p80: Call spi_mem_get_name() to let controller set a custom name Date: Thu, 5 Jul 2018 14:56:28 +0200 Message-ID: <20180705145628.57a48e87@bbrezillon> References: <1530789310-16254-1-git-send-email-frieder.schrempf@exceet.de> <1530789310-16254-3-git-send-email-frieder.schrempf@exceet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, richard@nod.at, miquel.raynal@bootlin.com, broonie@kernel.org, david.wolfe@nxp.com, fabio.estevam@nxp.com, prabhakar.kushwaha@nxp.com, yogeshnarayan.gaur@nxp.com, han.xu@nxp.com, shawnguo@kernel.org, Cyrille Pitchen , Hou Zhiqiang , Philipp Puschmann , linux-kernel@vger.kernel.org To: Frieder Schrempf Return-path: In-Reply-To: <1530789310-16254-3-git-send-email-frieder.schrempf@exceet.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Thu, 5 Jul 2018 13:14:58 +0200 Frieder Schrempf wrote: > By calling spi_mem_get_name(), the driver of the (Q)SPI controller can > set a custom name for the memory device if necessary. > This is useful to keep mtdparts compatible when controller drivers are > ported from the MTD to the SPI layer. > > Signed-off-by: Frieder Schrempf > --- > drivers/mtd/devices/m25p80.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > index e84563d..482f0ef 100644 > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -199,8 +199,7 @@ static int m25p_probe(struct spi_mem *spimem) > hwcaps.mask |= SNOR_HWCAPS_READ_1_2_2; > } > > - if (data && data->name) > - nor->mtd.name = data->name; > + nor->mtd.name = spi_mem_get_name(spimem); Hm, not sure you can do that without breaking setup that pass a flash_platform_data object with a name. Also, you should keep the name extracted from the label property if any (this is done earlier, when spi_nor_set_flash_node() is called). if (data && data->name) nor->mtd.name = data->name; if (!nor->mtd.name) nor->mtd.name = spi_mem_get_name(spimem); > > /* For some (historical?) reason many platforms provide two different > * names in flash_platform_data: "name" and "type". Quite often name is