linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Rob Herring <robh@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, kernel@collabora.com
Subject: [DISCUSSION] spi multi chipselect support
Date: Wed, 18 Jul 2018 18:35:30 +0200	[thread overview]
Message-ID: <20180718163530.zsa5md3huz3dnotb@earth.universe> (raw)

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

Hi Mark,

Some SPI slave devices have more than one chip select [0]. Rob suggested
to use the following DT notation for this [1]:

spi-controller {
    slave@0 {
        reg = <0>, <1>;
    };
};

I think this makes sense from a DT point of view, but this needs
quite some changes in the SPI core. I tried to find out, how to
implement the suggestion in the last few days and I see two
possibilities:

1. Register two SPI Linux devices from one DT node. This needs the
   fewest changes in SPI core. But we loose the one-to-one mapping
   of DT nodes to devices. I have a feeling, that this will backfire.

2. Add support for multiple chip-select to spi_device and modify
   the transfer functions to make use of this. Unfortunately this
   would require changing all spi controller as far as I can see?

Can you please advise me how to proceed?

Thanks,

-- Sebastian

[0] For example microcontrollers with ISP (in-system programming)
    interface, like the NXP Kinetis K20 series or the MRF89XA,
    which has one chip-select for configuration register access
    and one for FIFO access
[1] https://patchwork.kernel.org/patch/10310109/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2018-07-18 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 16:35 Sebastian Reichel [this message]
2018-07-18 17:19 ` [DISCUSSION] spi multi chipselect support Lars-Peter Clausen
2018-07-19 13:25   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180718163530.zsa5md3huz3dnotb@earth.universe \
    --to=sebastian.reichel@collabora.co.uk \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).