From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Frieder Schrempf <frieder.schrempf@exceet.de>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, richard@nod.at, broonie@kernel.org,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
cyrille.pitchen@wedev4u.fr, pp@emlix.com, Zhiqiang.Hou@nxp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] mtd: m25p80: Call spi_mem_get_name() to let controller set a custom name
Date: Thu, 2 Aug 2018 15:14:34 +0200 [thread overview]
Message-ID: <20180802151434.6c978937@bbrezillon> (raw)
In-Reply-To: <1533214434-28761-4-git-send-email-frieder.schrempf@exceet.de>
On Thu, 2 Aug 2018 14:53:54 +0200
Frieder Schrempf <frieder.schrempf@exceet.de> wrote:
> By calling spi_mem_get_name(), the driver of the (Q)SPI controller can
> set a custom name for the memory device if necessary.
> This is useful to keep mtdparts compatible when controller drivers are
> ported from the MTD to the SPI layer.
>
> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de>
Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/mtd/devices/m25p80.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index e84563d..aac48800 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -202,6 +202,9 @@ static int m25p_probe(struct spi_mem *spimem)
> if (data && data->name)
> nor->mtd.name = data->name;
>
> + if (!nor->mtd.name)
> + nor->mtd.name = spi_mem_get_name(spimem);
> +
> /* For some (historical?) reason many platforms provide two different
> * names in flash_platform_data: "name" and "type". Quite often name is
> * set to "m25p80" and then "type" provides a real chip name.
next prev parent reply other threads:[~2018-08-02 13:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 12:53 [PATCH v3 0/3] Extend the SPI mem interface to set a custom memory name Frieder Schrempf
2018-08-02 12:53 ` [PATCH v3 1/3] spi: spi-mem: Fix a typo in the documentation of struct spi_mem Frieder Schrempf
2018-08-02 13:09 ` Boris Brezillon
2018-08-02 13:39 ` Frieder Schrempf
2018-08-02 14:35 ` Mark Brown
2018-08-02 14:58 ` Applied "spi: spi-mem: Fix a typo in the documentation of struct spi_mem" to the spi tree Mark Brown
2018-08-02 12:53 ` [PATCH v3 2/3] spi: spi-mem: Extend the SPI mem interface to set a custom memory name Frieder Schrempf
2018-08-02 13:12 ` Boris Brezillon
2018-08-02 12:53 ` [PATCH v3 3/3] mtd: m25p80: Call spi_mem_get_name() to let controller set a custom name Frieder Schrempf
2018-08-02 13:14 ` Boris Brezillon [this message]
2018-08-02 14:58 ` Applied "mtd: m25p80: Call spi_mem_get_name() to let controller set a custom name" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802151434.6c978937@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@exceet.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=pp@emlix.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).