From: Mark Brown <broonie@kernel.org>
To: Kirill Kapranov <kirill.kapranov@compulab.co.il>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
l.stach@pengutronix.de
Subject: Re: [PATCH] spi:fix IDR collision on systems with both fixed and dynamic SPI bus numbers
Date: Tue, 14 Aug 2018 15:18:59 +0100 [thread overview]
Message-ID: <20180814141859.GC5810@sirena.org.uk> (raw)
In-Reply-To: <20180813164810.16769-1-kirill.kapranov@compulab.co.il>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Mon, Aug 13, 2018 at 07:48:10PM +0300, Kirill Kapranov wrote:
> On systems where some controllers get a dynamic ID assigned and some have
> a fixed number (e.g. from ACPI tables), the current implementation might
> run into an IDR collision: in case of a fixed bus number is gotten by a
> driver (but not marked busy in IDR tree) and a driver with dynamic bus
> number gets the same ID and predictably fails.
Is this something that's actually happened for you?
> + } else {
> + /* devices with a fixed bus num must check-in with the num */
> + mutex_lock(&board_lock);
The indentation here is weird, the comment isn't aligned with the code
it's commenting on.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-14 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 16:48 [PATCH] spi:fix IDR collision on systems with both fixed and dynamic SPI bus numbers Kirill Kapranov
2018-08-14 14:18 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-13 15:59 [PATCH] spi: fix " Lucas Stach
[not found] ` <20171013155946.1486-1-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-13 16:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814141859.GC5810@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kirill.kapranov@compulab.co.il \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).