From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [RFC/RFT PATCH v1 0/9] mtd: fsl: quadspi: Fixes for fsl-quadspi.c driver (vybrid HW) Date: Sun, 30 Sep 2018 18:22:20 +0200 Message-ID: <20180930182220.30d0ccf3@jawa> References: <20180926220739.620-1-lukma@denx.de> <20180929000359.34fe18ae@bbrezillon> <20180929230240.1c8d844d@jawa> <20180930073927.001c16d2@bbrezillon> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/gQ0Z.Lv4IK3bPj90mSrGgqu"; protocol="application/pgp-signature" Cc: Fabio Estevam , prabhakar.kushwaha@nxp.com, han.xu@nxp.com, Mark Rutland , yogeshnarayan.gaur@nxp.com, richard@nod.at, linux-kernel@vger.kernel.org, Stefan Agner , linux-spi@vger.kernel.org, albert.aribaud@3adev.fr, Frieder Schrempf , broonie@kernel.org, linux-mtd@lists.infradead.org, Fabio Estevam , david.wolfe@nxp.com, computersforpeace@gmail.com, dwmw2@infradead.org To: Boris Brezillon Return-path: In-Reply-To: <20180930073927.001c16d2@bbrezillon> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org --Sig_/gQ0Z.Lv4IK3bPj90mSrGgqu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Boris, > Hi Lukasz, >=20 > On Sat, 29 Sep 2018 23:02:40 +0200 > Lukasz Majewski wrote: >=20 > > > Talking about that, can you try to port your fixes on top of > > > Frieder's patchset? I'm pretty sure some bug fixes are irrelevant > > > after the migration to spi-mem (patch 1, 3, 4, 5, 6, 7 and 9 > > > should be dropped I think). =20 > >=20 > > The problem is that Frieder's patch is using IP command mode for > > transfers smaller than AHB RX fifo size. > > This according to the comment in the current driver is broken in HW > > for Vybrid (so this is a regression). =20 >=20 > Why not fixing that in the new driver? I did not say that I will not fix it in the new driver :-) The problem is that I'm waiting for NXP's community reply - to get some more info regarding the bug. >=20 > >=20 > > I'm also wondering if other users of vf610 based boards experience > > issues with QSPI? =20 >=20 > Are you sure the 4 I/O lines are wired on your design?=20 This is a somewhat special case. There are two identical SPI-NOR memories: one with QUAD lines connected and second only for DUAL due to HW design decision. > Anyway, if it's > a bug that only hurts vf610, you should mask quad modes in ->hwcaps > (or patch fsl_qspi_supports_op() in the new driver), not change the > SPI NOR definition. Yes, this was also pointed out by Cyrille - and yes, I do agree that I shouldn't mask it. >=20 > >=20 > > In my case, after running the UBI/UBIFS tests (on the original and > > new driver without those "fixes") I cannot mount the volume after > > creation as the header is wrongly read. =20 >=20 > I'm not denying this fact, I'm just saying, now that you've found > where the issue comes from, you can also port the fix to the new > driver. Yes, as the old driver is now in a "good enough" shape (though I don't know the exact HW bug reason) - the code can be ported to the new driver. >=20 > Regards, >=20 > Boris >=20 > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de --Sig_/gQ0Z.Lv4IK3bPj90mSrGgqu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAluw+D0ACgkQAR8vZIA0 zr146Af/dhtgZ/5O+ftarCkoh9hIJfxK8FtCQq5b7Hkn1jTcXEMBLGfANjyJdI1Y Xttr/TthJg3CiP39pT5gzwUKb8d+UtAEqsDY1NXCob13frFBTQp/n6o5vLgBaZxr byMwlDs/BaITsof0O6c2yq6j3OHVEWg28wXd8usK4R9V3N6w9YZmAVPPpvsDGfmY egeGAeQc3TjZItMdNLme8sCz4hmXJaXsiHoNY2Gf/nG4XRe+y2oO2nG01dwpjxae xGjwngWsgizShYrlWUAU7gMxkcH3PZ8F+68esDjFzzvXHNAeGSpqzxcIISw8uYtU chcHEIFwQY5J8yd3BN//yobEPW0hfA== =jIv+ -----END PGP SIGNATURE----- --Sig_/gQ0Z.Lv4IK3bPj90mSrGgqu--