From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: gustavo@embeddedor.com, linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: slave: Fix missing break in switch
Date: Wed, 3 Oct 2018 16:01:11 +0100 [thread overview]
Message-ID: <20181003150111.GD7132@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdX2YL2PG390ej0WMct7DciAbzO=66z7TJ-VnS8_phjdaQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Wed, Oct 03, 2018 at 04:46:45PM +0200, Geert Uytterhoeven wrote:
> On Wed, Oct 3, 2018 at 2:57 PM Gustavo A. R. Silva
> > case CMD_REBOOT:
> > dev_info(&priv->spi->dev, "Rebooting system...\n");
> > kernel_restart(NULL);
> > + break;
> Alternatively, kernel_restart() and friends could be marked __noreturn.
Yes, that seems more sensible though there's no harm in this patch even
with that. It'd definitely avoid other issues in future.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-10-03 15:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 12:33 [PATCH] spi: slave: Fix missing break in switch Gustavo A. R. Silva
2018-10-03 14:46 ` Geert Uytterhoeven
2018-10-03 15:01 ` Mark Brown [this message]
2018-10-03 15:05 ` Gustavo A. R. Silva
2018-10-03 15:10 ` Geert Uytterhoeven
2018-10-03 18:22 ` Gustavo A. R. Silva
2018-10-03 15:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003150111.GD7132@sirena.org.uk \
--to=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).