From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v5 3/9] spi: Add a driver for the Freescale/NXP QuadSPI controller Date: Thu, 15 Nov 2018 14:12:52 +0100 Message-ID: <20181115141252.52a5b32d@bbrezillon> References: <1542116782-13118-1-git-send-email-frieder.schrempf@kontron.de> <1542116782-13118-4-git-send-email-frieder.schrempf@kontron.de> <65577d13-b17d-8f69-313c-01d23240d1d9@kontron.de> <3e9aa917-cf3a-cf0e-8516-4e73d30eb2a1@kontron.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Yogesh Narayan Gaur , "linux-mtd@lists.infradead.org" , "linux-spi@vger.kernel.org" , Marek Vasut , Mark Brown , Han Xu , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "richard@nod.at" , "miquel.raynal@bootlin.com" , David Wolfe , Fabio Estevam , "Prabhakar Kushwaha" , "shawnguo@kernel.org" , "linux-kernel@vger.kernel.org" To: Schrempf Frieder Return-path: In-Reply-To: <3e9aa917-cf3a-cf0e-8516-4e73d30eb2a1@kontron.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Thu, 15 Nov 2018 11:43:05 +0000 Schrempf Frieder wrote: > On 15.11.18 07:22, Yogesh Narayan Gaur wrote: > > Hi Frieder, > > > > With below patch on top of your v5, Read/Write/Erase on CS1 is working fine for me. > > Ok, are you sure, that AHB read is working too with this patch? > You are removing the memmap_phy offset from SFAR and the SFXXAD register > values. > > I can understand that selection of the CS and IP commands will work like > this, but I can't understand how AHB read should work without the base > address of the mapped memory. > > I'm afraid I still don't fully understand the background of these > things, Same here. Yogesh, can you give us more detail on why you decided to drop the memmap_phy offset? > but still thank you for testing. >