From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Brown <broonie@kernel.org>,
cyrille.pitchen@microchip.com, stable@vger.kernel.org,
Piotr Bugalski <bugalski.piotr@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: atmel-quadspi: disallow building on ebsa110
Date: Mon, 10 Dec 2018 23:21:02 +0100 [thread overview]
Message-ID: <20181210232102.13ab5178@bbrezillon> (raw)
In-Reply-To: <20181210203837.2118450-1-arnd@arndb.de>
Hi Arnd,
Should be prefixed with "spi: atmel-quadspi: " now ;-).
On Mon, 10 Dec 2018 21:38:16 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> I ran into a link-time error with the atmel-quadspi driver on the
> EBSA110 platform:
>
> drivers/mtd/built-in.o: In function `atmel_qspi_run_command':
> :(.text+0x1ee3c): undefined reference to `_memcpy_toio'
> :(.text+0x1ee48): undefined reference to `_memcpy_fromio'
>
> The problem is that _memcpy_toio/_memcpy_fromio are not available on
> that platform, and we have to prevent building the driver there.
>
> In case we want to backport this to older kernels: between linux-4.8
> and linux-4.20, the Kconfig entry was in drivers/mtd/spi-nor/Kconfig
> but had the same problem.
>
> Link: https://lore.kernel.org/patchwork/patch/812860/
> Fixes: 161aaab8a067 ("mtd: atmel-quadspi: add driver for Atmel QSPI controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 55d5ffb50750..9f89cb134549 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -93,7 +93,7 @@ config SPI_AT91_USART
>
> config SPI_ATMEL_QUADSPI
> tristate "Atmel Quad SPI Controller"
> - depends on ARCH_AT91 || (ARM && COMPILE_TEST)
> + depends on ARCH_AT91 || (ARM && COMPILE_TEST && !ARCH_EBSA110)
> depends on OF && HAS_IOMEM
> help
> This enables support for the Quad SPI controller in master mode.
next prev parent reply other threads:[~2018-12-10 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 20:38 [PATCH] mtd: atmel-quadspi: disallow building on ebsa110 Arnd Bergmann
2018-12-10 22:21 ` Boris Brezillon [this message]
2018-12-11 1:16 ` Applied "mtd: atmel-quadspi: disallow building on ebsa110" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210232102.13ab5178@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=bugalski.piotr@gmail.com \
--cc=cyrille.pitchen@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).