From: Mark Brown <broonie@kernel.org>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: lpspi: Add cs-gpio support
Date: Tue, 11 Dec 2018 14:26:11 +0000 [thread overview]
Message-ID: <20181211142611.GF6686@sirena.org.uk> (raw)
In-Reply-To: <20181204062313.28942-1-xiaoning.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Tue, Dec 04, 2018 at 06:24:59AM +0000, Clark Wang wrote:
> Add cs-gpio feature for LPSPI. Use fsl_lpspi_prepare_message() and
> fsl_lpspi_unprepare_message() to enable and control cs line.
> These two functions will be only called at the beginning and the ending
> of a message transfer.
> Still support using the mode without cs-gpio. It depends on if attribute
> cs-gpio has been configured in dts file.
Why is this not using the core support for GPIO chip selects? Note that
you can't just implement chip select in the prepare and unprepare,
drivers can toggle chip select within a message so the code should be
looking at the individual transfers to see if cs_change is set and
acting accordingly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-12-11 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 6:24 [PATCH] spi: lpspi: Add cs-gpio support Clark Wang
2018-12-11 14:26 ` Mark Brown [this message]
2018-12-12 2:12 ` Clark Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211142611.GF6686@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).